Bug Not a bug Cant stop it asking for 1% donation

Matt

New Member
Joined
Apr 24, 2019
Messages
5
I want to allow users to buy/sell then donate a % only if they wish. I've tried every config and no matter what it asks for 1% donation.

I'm in individual mode, I've tried Percentage of sales- None, permission based and specified vale (entered 0).

In the global options I have Maximum percentage amount set to 0

In the usergroupos permission I have 'Percentage on sales (if permission based) set as unlimited (also tried 0).

It still asks for 1% even though I've not specified 1% anywhere.

Is it not possible to not ask for a forced percentage or am I doing something wrong?

Also, if you leave an empty postage option it errors out. For user experience it might be nice to have validation on sale creation to not allow a blank shipping option.
 

MtoR

Freaky Coder
Staff member
Joined
Nov 14, 2015
Messages
3,915
No percentage are either mandatory or disabled.
 

Matt

New Member
Joined
Apr 24, 2019
Messages
5
No percentage are either mandatory or disabled.
That's a shame as I can see potential for setting up a % fee for standard members and no fee for upgraded members, possibly something to consider in the future.

How would I go about removing the fee for all? Setting 'Percentage on sales (Individual mode)' to 'None' Still asks for a 1% donation?
 

MtoR

Freaky Coder
Staff member
Joined
Nov 14, 2015
Messages
3,915
That's a shame as I can see potential for setting up a % fee for standard members and no fee for upgraded members, possibly something to consider in the future.

How would I go about removing the fee for all? Setting 'Percentage on sales (Individual mode)' to 'None' Still asks for a 1% donation?
Hum really ? You sure you didn't set it globally ?
 

Matt

New Member
Joined
Apr 24, 2019
Messages
5
Hum really ? You sure you didn't set it globally ?
It's possible i'm missing something obvious. This is the current config

Global settings:

global.jpg

Node settings:
node.jpg

Example of usergroup permissions (all the same - also tried unlimited)
example-perms.jpg

Front end:
front-end-sales.jpg
 

MtoR

Freaky Coder
Staff member
Joined
Nov 14, 2015
Messages
3,915
Hum no seems fine.
Btw, you saw in global settings there is in fact an option to allow percentage donation (ie. user choice to do so).
 

Matt

New Member
Joined
Apr 24, 2019
Messages
5
Hum no seems fine.
Btw, you saw in global settings there is in fact an option to allow percentage donation (ie. user choice to do so).
The user choice one was still asking for a 1% donation. I disabled the add-on until I had time to look into it more. Disabling the add-on broke the ability to create any topics on my forum with this error

PHP:
XF\Db\Exception: MySQL query error [1364]: Field 'xfa_fss_shipping' doesn't have a default value src/XF/Db/AbstractStatement.php:217
 

MtoR

Freaky Coder
Staff member
Joined
Nov 14, 2015
Messages
3,915
I'll have to provide a bug fix release for that.
 

MtoR

Freaky Coder
Staff member
Joined
Nov 14, 2015
Messages
3,915
I have tried to investigate the 1% thing while doing the bug fix version.
I am totally unable to reproduce that.

I have the exact same configuration you have and no 1% stated.
Could you please check your db the xf_thread table and tell me what you have in the xfa_fss_percentage column for the corresponding thread (thread_id).

clément
 

Matt

New Member
Joined
Apr 24, 2019
Messages
5
Ok so I re-installed the addon to look at the table but now the addon appears to be working as expected. I've set it so the user can set a percentage of donation and all seems good!
 
  • Like
Reactions: MtoR