Bug Resolved Counter on tournament page is wrong

[Frode Hanoy]

It doesn't count the tournament in said category correctly.

 

[EazyEazy]

Has this been fixed before I upgrade @Clement

 

[Clement]

@EazyEazy same answer obviously...

@Frode Hanoy is the tournament not under moderation ? Did you get any error in the log ?

 

[Frode Hanoy]

@EazyEazy same answer obviously...

@Frode Hanoy is the tournament not under moderation ? Did you get any error in the log ?

No errors.
Under moderation, what do you mean by that?
It is currently running. But it should still show up in the counter.
Link if you want to see: https://www.boardgamedungeon.net/tournaments/terraforming-mars-1v1-tournament-30-usd-first-prize.7/

 

[Clement]

Was the tournament created as a private tournament ?

 

[Frode Hanoy]

Was the tournament created as a private tournament ?

Nope. Was open for public registration.

 

[Clement]

Hum ok I'll investigate it's strange considering the code

 

[Frode Hanoy]

Update on this?

 

[Clement]

I haven't yet had time to work on tournament.

Clément

 

[Clement]

@Frode Hanoy I wasn't able to reproduce it.

Have you tried adding another tournament to see if you still have that issue ?
I would recommend you rebuild the counters too.

 

[Frode Hanoy]

I know now what is wrong. If you select PRIVATE tournament (so invite only), it won't show in the counters.. But that doesn't make sense. I want tournaments to show up in the counters, even if they are invite-only..

 

[Clement]

Ohhhhh good catch, yeah I think that's as designed.
I think my intent behind that was the fact that people that can't seem them would find it odd to see 1 while they see nothing.
And making the count adapted to effective user view wouldn't work as those things are cached.

Or I could make it as an option for the admin to choose them to be counted or not, what do you think ?

 

[Frode Hanoy]

Yeah that sounds good

 

[Clement]

I'll consider that in the next release then