Bug Fixed "Message user info icons position" Does not work properly

[Nicolas]

The "Message user info icons position" option does not seem to be working properly.
If I select "above avatar" it works fine and displays the trophies:

https://img.hogwarts.nz/img/Screenshot%202023-07-21%20093216.png

But I actually want trophies at the end of user info (here are my ideal settings: https://img.hogwarts.nz/img/Screenshot 2023-07-21 093246.png )

And if I choose that or any other option it doesn't show at all: https://img.hogwarts.nz/img/Screenshot 2023-07-21 093302.png

Example thread:

3️⃣ Movie Marathon: Harry Potter and the Prisoner of Azkaban

EDIT: We're now watching the Prisoner of Azkaban! Feel free to share any reflections up until this movie! :) Hey good people! I was considering watching through the HP movies again (which I haven't done in a very long time - LotR gets at least an anual viewing and Harry Potter... has not, some...

hogwarts.nz

Summary: Only the "above avatar" option displays trophies in posts. Any other option trophies do not display.

 

[Clement]

Could be because of your custom style templates being way different from original.

Were you able to test on the default style ?

 

[Nicolas]

Yes, same issue on default style

 

[Clement]

I'll have to check then and see if something changed in the latest versions

 

[yrex]

message_macros template has been updated so this add-on is no longer fully compatible, you guys need to update the addon as well

 

[Nicolas]

I just made a completely clean Xenforo install with this being the only add-on and can confirm that the only option which works for displaying trophies is "above avatar" - which is very unfortunate!

 

[Nicolas]

Apologies for the double post, I did some hunting for you.


"Add trophies/level to postbit - after banners" is trying to find:

<xf:userbanners user="$user" tag="div" class="message-userBanner" itemprop="jobTitle" />

But the template has been edited to and it sound be looking for:

<xf:userbanners user="$user" tag="div" class="message-userBanner" itemprop="{{ $includeMicrodata ? 'jobTitle' : '' }}" />

"Add badges to postbit - before banners" is trying to find:

<xf:usertitle user="$user" tag="h5" class="message-userTitle" banner="true" itemprop="jobTitle" />

But the template actually has:

            <xf:usertitle user="$user" tag="h5" class="message-userTitle" banner="true" itemprop="{{ $includeMicrodata ? 'jobTitle' : '' }}" />

"Add badges to postbit - below avatar" is looking for:

<h4 class="message-name"><xf:username user="$user" rich="true" defaultname="{$fallbackName}" itemprop="name" /></h4>

But the template has:

<h4 class="message-name"><xf:username user="$user" rich="true" defaultname="{$fallbackName}" itemprop="{{ $includeMicrodata ? 'name' : '' }}" /></h4>

and finally "Add badges to postbit - bottom user info" is trying to locate:

#(<section itemscope itemtype="https://schema.org/Person".*)(</section>)#sU

But the format for that section is now:

<section class="message-user"
        {{ $includeMicrodata ? 'itemprop="' . $itemProp . '" itemscope itemtype="https://schema.org/Person" itemid="' . ($user ? link('canonical:members', $user) : '') . '"' : '' }}>

All of this is related to the XF 2.2.13 update which improved "structured metadata"

XenForo 2.2.13 Released

XenForo 2.2.13 Released XenForo 2.2.13 is now available for all licensed customers to download. We strongly recommend that all customers running previous versions of XenForo 2.2 upgrade to this release to benefit from increased stability. In addition to the fixes listed below, we have a few...

xenforo.com

It should be fairly simple for you to update template_modifications.xml with this information and fix this bug.

 

[Clement]

Oh thanks, I’ll provide a new version when I get back from vacations.

I’ll have to deal with the change to keep compatibility.

 

[yrex]

This has not be updated right? So there's no point in renewing my license for this addon.

 

[Nicolas]

This has not be updated right? So there's no point in renewing my license for this addon.

That's right. Even though how to resolve it for the most recent XF release is right there for them, still no official fix.

And with new XF releases around the corner I'm really not confident in any timely updates for that, either.

 

[yrex]

I'd say the add-ons are dead now. They have no plans to update or improve it anymore. Hopefully they'll sell the addons to other developers and let it continue. The addons are really good but need to maintained regularly.

 

[Clement]

It's not dead, I just had a terrible year so less time to work on xF stuff (which is not my main job).

I'll work on my addons during the upcoming holidays.

Clément

 

[Nicolas]

Sorry to hear about the awful year, Clément - but many thanks for the update and the fix.

Joyeux Noël et bonne année! Hope the new year is better.