1. This area is dedicated to the support of our xF1 add-ons. For xF2, please use the dedicated area: HERE.
Dismiss Notice
We have just posted about our product policy for XF2.
Click HERE to view it.

Bug Fixed Multiple buyers, race condition

Discussion in 'RM Marketplace' started by apsmith21, Jun 22, 2017.

  1. apsmith21

    apsmith21 Member

    Joined:
    Oct 2, 2016
    Messages:
    73
    Likes Received:
    3
    If the marketplace listing is close to selling out, there have been a couple of times where the physical product listing is oversold.

    It happens when there are still items listed for sale, but the buyers enter the transaction around the same time, but have not completed the paypal payment yet.

    When they return to the forums, they were allowed to purchase the item, even though the listing was sold out.

    Now the listing is "oversold" even though the box to oversell the listing is not checked.
     
    Freelancer likes this.
  2. MtoR

    MtoR Freaky Coder
    Staff Member

    Joined:
    Nov 14, 2015
    Messages:
    4,302
    Likes Received:
    646
    Hum, I would need perhaps to put some sort of on hold quantity with a timeout to cope with that.

    Clément
     
    Freelancer likes this.
  3. Freelancer

    Freelancer Member

    Joined:
    Nov 17, 2015
    Messages:
    283
    Likes Received:
    20
    I experienced this with "Forum Sales" add-on. It's a critical thing (more with Marketplace of course).
     
    apsmith21 likes this.
  4. apsmith21

    apsmith21 Member

    Joined:
    Oct 2, 2016
    Messages:
    73
    Likes Received:
    3
    Just a +1 to this - we had a listing oversell by a number of copies because of this exact problem. Had a very limited supply, a crap ton of people went after the listing to purchase, and a very large number of them got to paypal and were able to pay for a copy, even though the supply did not warrant it.

    I don't know what the best solution here is, but it's a bigger deal for me.
     
  5. MtoR

    MtoR Freaky Coder
    Staff Member

    Joined:
    Nov 14, 2015
    Messages:
    4,302
    Likes Received:
    646
    Hum, I may have to put some sort of on-hold timeout system.

    Though it was somehow what I had before and people weren't that happy.
     
    Freelancer likes this.
  6. Freelancer

    Freelancer Member

    Joined:
    Nov 17, 2015
    Messages:
    283
    Likes Received:
    20
    Just thinking out loud: what about having a limit of sending a request to PayPal from the particular sale depending on the quantity there. No timing limiter but a communication limiter with PayPal, and the second request gets an error message like "Sorry, someone else purchased this item". If possible. A "Timer" could provoke other issues.
     
  7. MtoR

    MtoR Freaky Coder
    Staff Member

    Joined:
    Nov 14, 2015
    Messages:
    4,302
    Likes Received:
    646
    Hum not sure to get your point
     
  8. Freelancer

    Freelancer Member

    Joined:
    Nov 17, 2015
    Messages:
    283
    Likes Received:
    20
    Can you detect the amount of purchase requests made versus the amount of items available (quantity of the sale offer)? If so if the purchase is requested the same amount of quantity of the item sold you could block any excess purchase requests by an error message.

    I think this works better than a timer?
     
  9. MtoR

    MtoR Freaky Coder
    Staff Member

    Joined:
    Nov 14, 2015
    Messages:
    4,302
    Likes Received:
    646
    Yes this is what I suggested here above, the only issue is that it needs to have a timeout on the purchase request because one could go to paypal and decide not to continue the purchase and just leave like that.
     
    Freelancer likes this.
  10. MtoR

    MtoR Freaky Coder
    Staff Member

    Joined:
    Nov 14, 2015
    Messages:
    4,302
    Likes Received:
    646
    Have added some more quantity checks, this should do it.
     
  11. apsmith21

    apsmith21 Member

    Joined:
    Oct 2, 2016
    Messages:
    73
    Likes Received:
    3
    Thanks, I'm going to try this out soon. :)
     
  12. apsmith21

    apsmith21 Member

    Joined:
    Oct 2, 2016
    Messages:
    73
    Likes Received:
    3
    This issue was definitely not resolved for us, still a major problem. If there is a small quantity, say 3-4 items, and multiple buyers want it, we've seen the potential to oversell the listing by 10+ items, even though the listing is not allowed to oversell.

    Did this get resolved in the Xenforo 2.0 version, or are there more checks beyond what is installed in this version...?
     
  13. MtoR

    MtoR Freaky Coder
    Staff Member

    Joined:
    Nov 14, 2015
    Messages:
    4,302
    Likes Received:
    646
    I didn't integrate further check, I am just not sure when this happen.
    I think it's cases when the user have reached the payment page because the sale is effective only once the redirection has been done.

    I could put an additional security that block quantity for a defined timeout.
     
  14. apsmith21

    apsmith21 Member

    Joined:
    Oct 2, 2016
    Messages:
    73
    Likes Received:
    3
    I think that seems likely - a number of people reach the payment page before the listing is showing sold out.

    At my forums, we literally could have 30 members vying for 10 physical items at the same time.

    Would you be able to implement this additional security in the Xenforo 1.x version?

    Thanks
     
  15. MtoR

    MtoR Freaky Coder
    Staff Member

    Joined:
    Nov 14, 2015
    Messages:
    4,302
    Likes Received:
    646
    I'll have to check.
     

Share This Page

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice