• This area is dedicated to the support of our xF1 add-ons. For xF2, please use the dedicated area: HERE.
  • We are aware that a no permission error was shown when you tried to purchase in the last 2 days, this is now fixed.

Bug Fixed NoName tag in most used thread tags section

pec

New Member
Joined
May 2, 2016
Messages
14
There seem to be a small bug in the query for the top thread tags.
The first one is always an empty one:

upload_2016-12-28_1-4-59.png
 

MtoR

Freaky Coder
Staff member
Joined
Nov 14, 2015
Messages
4,227
Thanks for reporting, will analyze it when back home.

Clément
 
  • Like
Reactions: pec

pec

New Member
Joined
May 2, 2016
Messages
14
Forgot to mention:
I did a quick check directly in the database.
There is no tag that is used more than the second one listed in the addon's top list.

Another strange thing: the last usage of first listed tag, the "no name" tag", is always "a moment ago" ;)
 
  • Like
Reactions: MtoR

MtoR

Freaky Coder
Staff member
Joined
Nov 14, 2015
Messages
4,227
Hello,

I don't have such a bug.

Can you please try to run the following query manually:
Code:
SELECT COUNT(*) AS nbItems,tag.*
FROM xf_tag_content AS tag_content
LEFT JOIN xf_tag AS tag ON (tag.tag_id=tag_content.tag_id)
WHERE content_type='thread'
GROUP BY tag_id
ORDER BY nbItems DESC
Clément
 

MtoR

Freaky Coder
Staff member
Joined
Nov 14, 2015
Messages
4,227
oO

It seems as if you have an empty tag with all null values, that's odd.
When you look into the table do you see that ?
 

pec

New Member
Joined
May 2, 2016
Messages
14
I can't find any empty tags, but some tags with 0 uses.
Means, there are some tags left, that do not have any assignments to threads anymore as they were removed from threads.
Some others were created in ACP, but were never used. last_use_date is then 0.
 

pec

New Member
Joined
May 2, 2016
Messages
14
If I extend the WHERE-clause by "AND last_use_date > 0" it works ;)

PHP:
SELECT COUNT(*) AS nbItems,tag.*
FROM xf_tag_content AS tag_content
LEFT JOIN xf_tag AS tag ON (tag.tag_id=tag_content.tag_id)
WHERE content_type='thread' AND last_use_date > 0
GROUP BY tag_id
ORDER BY nbItems DESC
 

MtoR

Freaky Coder
Staff member
Joined
Nov 14, 2015
Messages
4,227
Hum, it's odd anyways but will apply that fix.

Thanks
 
  • Like
Reactions: pec

pec

New Member
Joined
May 2, 2016
Messages
14
Thanks.

Another tag-related question ;)
the getTopTaggers function in tag.php isn't used somewhere in the add-on, isn't it ?
Would be interesting to know who is tagging the most content ;)
 

MtoR

Freaky Coder
Staff member
Joined
Nov 14, 2015
Messages
4,227
No it's not but feel free to open a request for it.
Just doing bug fixes for next release but the one after I may add new stuff.
 
  • Like
Reactions: pec