Bug Fixed Payment Marked as Unpaid Despite Successful Transaction

[VisEntities]

A user completed a purchase, and the payment went through successfully during the payment process. However, in the Sell dashboard, the transaction still shows as "Unpaid"

There’s also a server error being logged:

ErrorException: [E_WARNING] Attempt to read property "transaction_id" on null
File: src/addons/XFA/RMMarketplace/Purchasable/MarketplacePurchase.php:226
Generated by: Unknown account on Apr 20, 2025 at 7:34 PM

Stack trace:

#0 src/addons/XFA/RMMarketplace/Purchasable/MarketplacePurchase.php(226): XF::handlePhpError(2, '[E_WARNING] Att...', 's...', 226)
#1 src/XF/Payment/AbstractProvider.php(212): XFA\RMMarketplace\Purchasable\MarketplacePurchase->completePurchase(Object(XF\Payment\CallbackState))
#2 payment_callback.php(67): XF\Payment\AbstractProvider->completeTransaction(Object(XF\Payment\CallbackState))
#3 {main}

Request state:

array(4) {
  ["url"] => string(40) "/payment_callback.php?_xfProvider=stripe"
  ["referrer"] => bool(false)
  ["_GET"] => array(1) {
    ["_xfProvider"] => string(6) "stripe"
  }
  ["_POST"] => array(0) {
  }
}

 

[VisEntities]

Thing is he made a previous purchase that went okay

 

[Clement]

A user completed a purchase, and the payment went through successfully during the payment process. However, in the Sell dashboard, the transaction still shows as "Unpaid"

There’s also a server error being logged:

ErrorException: [E_WARNING] Attempt to read property "transaction_id" on null
File: src/addons/XFA/RMMarketplace/Purchasable/MarketplacePurchase.php:226
Generated by: Unknown account on Apr 20, 2025 at 7:34 PM

Stack trace:

#0 src/addons/XFA/RMMarketplace/Purchasable/MarketplacePurchase.php(226): XF::handlePhpError(2, '[E_WARNING] Att...', 's...', 226)
#1 src/XF/Payment/AbstractProvider.php(212): XFA\RMMarketplace\Purchasable\MarketplacePurchase->completePurchase(Object(XF\Payment\CallbackState))
#2 payment_callback.php(67): XF\Payment\AbstractProvider->completeTransaction(Object(XF\Payment\CallbackState))
#3 {main}

Request state:

array(4) {
  ["url"] => string(40) "/payment_callback.php?_xfProvider=stripe"
  ["referrer"] => bool(false)
  ["_GET"] => array(1) {
    ["_xfProvider"] => string(6) "stripe"
  }
  ["_POST"] => array(0) {
  }
}

View attachment 7312View attachment 7311

It happened only for one of your purchases ?
From my reading of the code, it would mean the purchase has not been logged by the xF payment profiles which I retrieve to get the payment method transaction id.
I can put something that avoids the error from being popped but it will mean that when this happens you don't get the transaction id.
I can't do anything about that.

Just out of curiosity, could it be a transaction you refunded and the refund was cancelled ?

 

[VisEntities]

It happened only for one of your purchases ?
From my reading of the code, it would mean the purchase has not been logged by the xF payment profiles which I retrieve to get the payment method transaction id.
I can put something that avoids the error from being popped but it will mean that when this happens you don't get the transaction id.
I can't do anything about that.

Just out of curiosity, could it be a transaction you refunded and the refund was cancelled ?

This's first time it happened today that his payment went through but wasn't marked as valid on seller dashboard

As for orders in seller dashboard showing no payment method but transaction id is shown that's been happening for dozen of orders already

 

[Clement]

And all of your payment provider have a title right ?

I'll fix by putting a safeguard but I don't understand why the info is missing there.
The log should be there and the provider should have a title.

 

[VisEntities]

Title yes, but not Display title (Same for PayPal)

 

[Clement]

Yeah well I don't think that's the reason then as you would never have it shown and you do have it sometimes.