Bug Fixed This is due to the fact that DigitalProduct is saved only on finalizeResourceCreate, and some of your addons tries to call canView()

[NICK97]

Unfortunately I have found this bug related to your add-ons and I have contact different developer to confirm the issue this is what’s he says

This is due to the fact that DigitalProduct is saved only on finalizeResourceCreate, and some of your addons tries to call canView() method for resource discussion thread BEFORE the resource saving is completed.


XFA\RMMarketplace\XF\Entity\Thread

public function canView(&$error = null)
    {
        $canView = parent::canView($error);
....
        // Has purchased product or own license
        if ($resource->xfa_rmmp_type == 'digital')
        {
            if ($resource->DigitalProduct // TODO: make sure it's exists since the resource type does not  mean that the relation is saved yet
              && $resource->DigitalProduct->hasValidLicense())
            {
                return true;
            }
        }
        else
        {
            if ($resource->ValidPurchase)
            {
                return true;
            }
        }

        return false;
    }

here some screenshots

 

[Clement]

When do you get that error exactly ?

 

[NICK97]

When do you get that error exactly ?

This happened if I check this box Restrict support thread access and created a resource with uploaded file and this is only happening if some of your addons tries to call canView() method for resource discussion thread BEFORE the resource saving is completed.

 

[Clement]

Ok noted , I'll have to investigate.

 

[NICK97]

Ok noted , I'll have to investigate.

Ok thank you

 

[Clement]

I just tried on a vanilla install but I can't reproduce that.

I am not calling canView so I guess this comes from another add-on you have ?

 

[Clement]

But ok I understand the fix

 

[NICK97]

But ok I understand the fix

Now I am confused have you fixed the issue? If yes when are you going to release the update?

 

[Clement]

I did apply the suggested modification yes.
I don't have an ETA, it will depends of what I implement.

 

[NICK97]

I did apply the suggested modification yes.
I don't have an ETA, it will depends of what I implement.

Ok thank you